[vlc-devel] [PATCH] HLS: hls_Download: don't put stream_Read in a loop

Jean-Paul Saman jpsaman at videolan.org
Fri Mar 30 11:02:06 CEST 2012

On Fri, Mar 30, 2012 at 10:48 AM, Frederic YHUEL <fyhuel at viotech.net> wrote:
> On Fri, Mar 30, 2012 at 10:24 AM, Jean-Paul Saman <jpsaman at videolan.org> wrote:
>> On Thu, Mar 29, 2012 at 2:34 PM, Frédéric Yhuel <fyhuel at viotech.net> wrote:
>>> Maybe I missed something, but it seems to me that either that patch must
>>> be applied, either "stream_Read" documentation must be fixed.
>> May I ask why this is necessary?
> Not necessary but cleaner.
>> I recall that some HLS servers report
>> 0 as segment size.
> Ok my bad, I did not understand. Would you put that explanation as a
> comment? It would be useful for those who read the code IMHO.

Would this suffice?

        /* NOTE: Beware the size reported for a segment by the HLS
server may not
         * be correct, when downloading the segment data. There for
check the size
         * and enlarge the segment data block if necessary.

Kind regards,

Jean-Paul Saman

More information about the vlc-devel mailing list