[vlc-devel] [vlc-commits] transcode: replace PICTURE_RING_BUFFER with picture_fifo_t

Ilkka Ollakka ileoo at videolan.org
Wed May 2 10:46:58 CEST 2012

On Wed, May 02, 2012 at 10:39:15AM +0200, Jean-Paul Saman wrote:
> vlc | branch: master | Jean-Paul Saman <jean-paul.saman at m2x.nl> | Tue Mar 27 10:16:15 2012 +0200| [0cdf8d8673bea62dd68937ec8037b860cac8ea66] | committer: Jean-Paul Saman

> transcode: replace PICTURE_RING_BUFFER with picture_fifo_t

> The PICTURE_RING_BUFFER used a fixed size, which when running out of available pictures
> produces visible artefacts in the encoded stream. Allocating a new picture and keeping
> track of them in a fifo is much simpler (in the multiple threads encoding scenario) and
> solves the ring buffer overrun.


Have you tested how this will behave when encoding is extremely slow? I
was wondering that is there any limit how large the fifo can be, other
than free memory.

Ilkka Ollakka
All power corrupts, but we need electricity.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120502/75e4f442/attachment.sig>

More information about the vlc-devel mailing list