[vlc-devel] [PATCH 0/3] Opengl to use GLSL 1.2

[Felix Paul Kühne]

Hey Ilkka,

thanks for your work!

On 04.05.2012, at 12:43, Ilkka Ollakka wrote:

> This is reworked opengl patch to opengl vout to use glsl 1.2 shader-code
> for yuv->rgb instead of assembly and arb extensions. It should help to have
> opengl vout for opengl ES 2.0 devices.

I had to hack your patch slightly to get it to compile for iOS as part of my current toy project:

add an "#include <OpenGLES/ES2/glext.h>" to opengl.h

add this block to the #ifdef __APPLE__ section in opengl.c:

#ifndef USE_OPENGL_ES
#   define PFNGLBINDVERTEXARRAYPROC          typeof(glBindVertexArrayAPPLE)*
#   define PFNGLDELETEVERTEXARRAYSPROC       typeof(glDeleteVertexArraysAPPLE)*
#   define PFNGLGENVERTEXARRAYSPROC          typeof(glGenVertexArraysAPPLE)*
#else
#   define PFNGLBINDVERTEXARRAYPROC          typeof(glBindVertexArrayOES)*
#   define PFNGLDELETEVERTEXARRAYSPROC       typeof(glDeleteVertexArraysOES)*
#   define PFNGLGENVERTEXARRAYSPROC          typeof(glGenVertexArraysOES)*
#   define GL_UNPACK_ROW_LENGTH 0
#endif

GL_UNPACK_ROW_LENGTH is undefined for iOS, since it isn't part of OpenGL ES, so this isn't a proper fix at all and leads to crashes on vout initialization.


Best regards,

Felix