[vlc-devel] [PATCH] file aout: do not apply volume (refs #6262)
Rafaël Carré
funman at videolan.org
Sun May 6 17:10:19 CEST 2012
Le 06/05/2012 08:21, Rémi Denis-Courmont a écrit :
> In my opinion, amplifying the audio that gets recorded to a file may do
> more harm than good. Indeed, there is no direct feedback to detect and
> correct saturation or distorsion.
Good idea, it can be amplified after the fact if needed with audacity
and such.
> ---
> modules/audio_output/file.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/modules/audio_output/file.c b/modules/audio_output/file.c
> index fb56805..e2c4e31 100644
> --- a/modules/audio_output/file.c
> +++ b/modules/audio_output/file.c
> @@ -193,10 +193,8 @@ static int Open( vlc_object_t * p_this )
> {
> p_aout->format.i_bytes_per_frame = AOUT_SPDIF_SIZE;
> p_aout->format.i_frame_length = A52_FRAME_NB;
> - aout_VolumeNoneInit( p_aout );
> }
> - else
> - aout_VolumeSoftInit( p_aout );
> + aout_VolumeNoneInit( p_aout );
>
> /* Channels number */
> i_channels = var_CreateGetInteger( p_this, "audiofile-channels" );
More information about the vlc-devel
mailing list