[vlc-devel] [PATCH] fix for fullscreen issue under xfce

Lars Mueller cobinja at yahoo.de
Mon May 7 23:55:07 CEST 2012

Am 07.05.2012 22:40, schrieb Rémi Denis-Courmont:
> An X11 client can only add or remove one EWMH state per message.
> 'setWindowState(windowState()&  ~Qt::WindowFullScreen)' removes
> the fullscreen state (NET_WM_STATE_FULSCREEN).
> Your patch both will first remove maximized in both dimensions, then remove
> fullscreen, then add maximized in both dimensions again. That is not only
> inefficient; that will cause unwarranted display glitches. I just checked with
> xtrace: VLC and Qt4 (4.8.1) seem to do the right thing: only the fullscreen
> state is toggled.


the problem I'm solving with the patch is described here:

The patch got corrupted by automatic line-wrap. I'm including it as an attachment here and sending it again to the list.

 > To me, either your window manager or your Qt4 version has a bug.

That's my opinion too. But nonetheless it's a bad idea to assign both maximized and fullscreen.
Which would be the one to be preferred by qt and or window manager?

Lars Mueller
mail    cobinja at yahoo.de
web     http://www.cobinja.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-fix-for-fullscreen-issue-under-xfce.patch
Type: text/x-patch
Size: 1765 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120507/909da7dc/attachment.bin>

More information about the vlc-devel mailing list