[vlc-devel] [vlc-commits] Add test case for the VLC binary

[Rafaël Carré]

Le 2012-05-09 12:53, Rémi Denis-Courmont a écrit :
> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed May  9 18:58:01 2012 +0300| [72fd19ba00ae7a30206969f4250bbda0ca28b3fe] | committer: Rémi Denis-Courmont
> 
> Add test case for the VLC binary
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=72fd19ba00ae7a30206969f4250bbda0ca28b3fe
> ---
> 
>  Makefile.am     |    2 ++
>  test/run_vlc.sh |    6 ++++++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index d4b8c38..e79bdae 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -477,6 +477,8 @@ endif
>  vlc$(EXEEXT):
>  	$(AM_V_GEN)$(LN_S) -f bin/vlc-static$(EXEEXT) vlc$(EXEEXT)
>  
> +TESTS = test/run_vlc.sh
> +

missing DIST entry?


>  ###############################################################################
>  # Installing plugins cache
>  ###############################################################################
> diff --git a/test/run_vlc.sh b/test/run_vlc.sh
> new file mode 100755
> index 0000000..df249ba
> --- /dev/null
> +++ b/test/run_vlc.sh
> @@ -0,0 +1,6 @@
> +#! /bin/sh

missing set -e ?

IIUC the script will return with the exit code of the last line.

> +
> +VLC="./vlc --ignore-config --no-one-instance-when-started-from-file"

This option is windows-only and has a meaning only if
--started-from-file is precised as well.

> +
> +$VLC -vv vlc://quit
> +$VLC -vv --play-and-exit vlc://nop