[vlc-devel] [vlc-commits] On Windows playing items like dvd:// or screen:// causes strange shortcuts in the user recently used folder.

[Rémi Denis-Courmont]

Le mardi 15 mai 2012 18:25:58 Jean-Baptiste Kempf, vous avez écrit :
> vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Tue May 15
> 17:24:33 2012 +0200| [391bb3272583cbe41c5dfec60141b76e9fd61d0e] |
> committer: Jean-Baptiste Kempf
> 
> On Windows playing items like dvd:// or screen:// causes strange shortcuts
> in the user recently used folder.
> 
> See
> http://social.technet.microsoft.com/Forums/nb-NO/w7itprogeneral/thread/02a
> 71215-e308-408c-94a6-81f5a8e564a6 for some information. The solution calls
> SHAddToRecentDocs only if make_path returns a valid path.
> 
> Patch by anonymous VlcVelope
> 
> Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=391bb3272583cbe41c
> > 5dfec60141b76e9fd61d0e
> 
> ---
> 
>  modules/gui/qt4/recents.cpp |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/modules/gui/qt4/recents.cpp b/modules/gui/qt4/recents.cpp
> old mode 100644
> new mode 100755
> index b07e796..5f97374
> --- a/modules/gui/qt4/recents.cpp
> +++ b/modules/gui/qt4/recents.cpp
> @@ -88,7 +88,9 @@ void RecentsMRL::addRecent( const QString &mrl )
> 
>  #ifdef WIN32
>      /* Add to the Windows 7 default list in taskbar */
> -    SHAddToRecentDocs( SHARD_PATHW, qtu( mrl ) );
> +    char* path = make_path( qtu( mrl ) );
> +    if( path )
> +        SHAddToRecentDocs( SHARD_PATHW, path );

WTF? Isn't this obviously leaking?

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis