[vlc-devel] [PATCH 2/5] libmp4: Add function MP4_BoxGetSmooBox()

Robert Forsman bob.forsman at ericsson.com
Tue May 22 17:52:18 CEST 2012


On Tue, 22 May 2012 11:11:09 -0400
Frédéric Yhuel <fyhuel at viotech.net> wrote:

> +MP4_Box_t *MP4_BoxGetSmooBox( stream_t *s )
> +{
> +    /* p_chunk is a virtual root container for the smoo box */
> +    MP4_Box_t *p_chunk;
> +    MP4_Box_t *p_smoo;
> +

After a couple of years of adding to my file analysis tool I found
myself looking at code and saying "where the hell did this come from?"
Especially on some of the more obscure stuff like various closed
caption formats.

I've never heard of a 'smoo' box, so it might help coders who come
along behind you to have a comment at the top of the function like

// ISO 14496-12 section 7.2.2.2

So they can find the specification that the code is based on.



More information about the vlc-devel mailing list