[vlc-devel] Notify plugins

[David Fuhrmann]

Hi,

I just modified the growl notification plugin and removed the problematic playlist_currentItem. Here is a current diff: http://pastebin.com/JHQjQxeC
I'm not sure if this completely prevents the duplicated notifications, but I imagine to notice a improvement.

The p_input->b_dead and !p_input cases are probably catched already by the code above. 
But I don't know why we should need to check input_GetItem(p_input)->psz_name? Could someone explain that?

But nevertheless, I will keep testing and if they is no opposition, I will commit these changes in some days.

Best,
David

Am 17.05.2012 um 18:57 schrieb Karlheinz Wohlmuth:

> Hi,
> 
> On May 15, 2012, at 9:16 PM, David Fuhrmann wrote:
> 
>> Hello,
>> 
>> Yeah, I already thought that the issue could be something like that. Thanks for fixing, now it works on my setup.
>> 
>> While the plugin seems to work somehow, they are a few problems I discovered: In some situations, an additional old item notification is followed by the new item notification, when the new one begins to play. Furthermore, I got a message while quitting.
> 
> yes, i saw that too. Did that not happen with the original code?
> 
>> At last, I just ran into the sort of crash Remi referred to. VLC does not crash every time a playlist item changes, I discovered the crash when there was only one item visible in the playlist.
>> Perhaps its a stupid question, but could it be possible to work around the problem by delaying the problematic part with performSelector(OnThread) or something like that?
> 
> If you mean delaying the call to playlist_CurrentInput() until its safe, i don't know if that would work.
> 
> Attached is a patch that follows the recommendation made by Rémi Denis-Courmont in the first mail in this thread. It removes the item-change callback as well as some checks for the remaining item-current callback (otherwise no notifications would be shown). I tested it with some local files and it seems to work. One ramification from the removed input_item_IsPreparsed() check is that files opened directly from Finder only show the filename instead of the metadata. Since i am not familiar with the VLC codebase, it might introduce other problems.
> 
> Felix:
> Thanks for applying the patch, i also see that you back-ported it. There are two strings marked as translatable that previously were not ("VLC media player" and "New input playing"). Could that cause problems?
> 
> Best regards
> <0001-Growl-remove-the-item-change-callback.patch>_______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel