[vlc-devel] [PATCH 3/5] libmp4: modify MP4_BoxGetNextChunk()

[Jean-Baptiste Kempf]

On Tue, May 22, 2012 at 05:11:10PM +0200, Frédéric Yhuel wrote :
> +    p_trash = calloc( 1, sizeof( MP4_Box_t ) );
> +    if( unlikely( p_trash == NULL ) )
> +        return NULL;

Missing extra line

> +    MP4_ReadBoxCommon( s, p_trash );
> +    if( (p_trash->i_type == ATOM_uuid && !CmpUUID( &p_trash->i_uuid, &SmooBoxUUID ))
> +            || p_trash->i_type == ATOM_ftyp )
> +        return p_trash;
> +    else
> +        free( p_trash );

Why?

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device