[vlc-devel] [PATCH] visual: remove depreciated vlc_object_alive
Rémi Denis-Courmont
remi at remlab.net
Sun May 27 19:01:24 CEST 2012
Le dimanche 27 mai 2012 19:27:05 Edward Wang, vous avez écrit :
> On 12-05-27 12:12 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> > Le dimanche 27 mai 2012 19:10:44 Edward Wang, vous avez écrit :
> >> ---
> >>
> >> modules/visualization/visual/visual.c | 19 +++++++++++++++----
> >> modules/visualization/visual/visual.h | 4 +++-
> >> 2 files changed, 18 insertions(+), 5 deletions(-)
> >
> > I don't see the point. This is not fixing the real problem, which is the
> > abuse of msleep().
>
> Well, I'm just trying to help contribute to the VLC project by removing
> the depreciated vlc_object_alive while waiting for you to write the
> vout_WaitPictureAvailable() function.
vlc_object_alive() is deprecated because it constitute a bad pattern, not just
for the heck of it.
Replacing a call to vlc_object_alive() just to hide the deprecation warning
and not actually fix the underlying issue is not good in my opinion.
--
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis
More information about the vlc-devel
mailing list