[vlc-devel] [PATCH] Fix win32 build errors

[Rémi Denis-Courmont]

On Mon, 28 May 2012 07:29:03 -0400, Edward Wang
<edward.c.wang at compdigitec.com> wrote:
> On 12-05-28 07:27 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
>> On Mon, 28 May 2012 07:22:15 -0400, Edward Wang
>> <edward.c.wang at compdigitec.com>  wrote:
>>> I'm not really sure, as j-b suggested.
>> Sorry, that's not an acceptable answer. Rejected.
>>
> Well, the VLC build for Win32 is broken right now, so your call.

And your patch suddenly breaks VLC support for non-686 and non-MMX
processors. The oldest VLC supported Windows version, XP only requires i586
(without MMX).

You could maybe argue that there is no point in supporting 586 or non-MMX
processors. But then the commit message is wrong. Also, if VLC requires a
higher processor than the operating system, then the installer needs to
check it.

-- 
Rémi Denis-Courmont
Sent from my collocated server