[vlc-devel] [PATCH] contribs: Update liba52 fixed patch

[Rémi Denis-Courmont]

On Mon, 12 Nov 2012 07:22:33 -0500, Edward Wang
<edward.c.wang at compdigitec.com> wrote:
> On 12-11-12 03:19 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
>> On Sun, 11 Nov 2012 22:20:13 -0500, Edward Wang
>> <edward.c.wang at compdigitec.com> wrote:
>>
>> Why? liba52 was not updated that I would be aware of.
>>
> Without this patch I cannot build liba52 from contribs:
> 
> (cd a52dec-0.7.4 && patch -p1) < ../../contrib/src/a52/liba52-fixed.diff
> patching file liba52/a52_internal.h
> patching file liba52/bit_allocate.c
> patching file liba52/bitstream.c
> patching file liba52/bitstream.h
> patching file liba52/config-a52.h
> patching file liba52/downmix.c
> patching file liba52/imdct.c
> Hunk #18 FAILED at 356.
> 1 out of 18 hunks FAILED -- saving rejects to file liba52/imdct.c.rej

Well sounds like someone messed up a previous contrib change. You should
revert that then.

Blindly patching files is not a good idea.

-- 
Rémi Denis-Courmont
Sent from my collocated server