[vlc-devel] [PATCH] contrib: postproc: HAVE_NEON should be 1

[Rémi Denis-Courmont]

Le dimanche 18 novembre 2012 04:14:14, Edward Wang a écrit :
> ---
>  contrib/src/postproc/rules.mak |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)

This does not make sense. HAVE_NEON shall either be undefined/uset or 
empty/zero when it is disabled, but not both. Please make up your mind.

> 
> diff --git a/contrib/src/postproc/rules.mak
> b/contrib/src/postproc/rules.mak index da28986..e449327 100644
> --- a/contrib/src/postproc/rules.mak
> +++ b/contrib/src/postproc/rules.mak
> @@ -24,12 +24,16 @@ endif
>  # ARM stuff
>  ifeq ($(ARCH),arm)
>  POSTPROCCONF += --disable-runtime-cpudetect --arch=arm
> +
>  ifdef HAVE_NEON
> +ifeq ($(HAVE_NEON),1)
>  POSTPROCCONF += --cpu=cortex-a8 --enable-neon
>  POSTPROC_CFLAGS +=-mfloat-abi=softfp -mfpu=neon
>  endif
>  endif
> 
> +endif
> +
>  # x86 stuff
>  ifeq ($(ARCH),i386)
>  POSTPROCCONF += --arch=x86

-- 
Rémi Denis-Courmont
http://www.remlab.net/