[vlc-devel] [PATCH] contrib: postproc: HAVE_NEON should be 1

Edward Wang edward.c.wang at compdigitec.com
Sun Nov 18 15:51:33 CET 2012

On 12-11-18 06:59 AM, Måns Rullgård <mans at mansr.com> wrote:
> "Rémi Denis-Courmont" <remi at remlab.net> writes:
>> Le dimanche 18 novembre 2012 04:14:14, Edward Wang a écrit :
>>> ---
>>>   contrib/src/postproc/rules.mak |    4 ++++
>>>   1 files changed, 4 insertions(+), 0 deletions(-)
>> This does not make sense. HAVE_NEON shall either be undefined/uset or
>> empty/zero when it is disabled, but not both. Please make up your mind.
>>>   ifdef HAVE_NEON
>>> +ifeq ($(HAVE_NEON),1)
> An empty value is equivalent to unset when tested with ifdef.
My problem was that HAVE_NEON was defined to 0, but the postproc didn't 
check if it was zero, just that it was defined. So even when I 
explicitly "export HAVE_NEON=0", postproc assumed that I wanted NEON.

Maybe I should just replace the "ifdef HAVE_NEON"with a "ifeq 
($(HAVE_NEON),1)" altogether?

         Edward Wang

More information about the vlc-devel mailing list