[vlc-devel] [PATCH] contrib: postproc: HAVE_NEON should be 1

[Rémi Denis-Courmont]

Le dimanche 18 novembre 2012 13:59:12, Måns Rullgård a écrit :
> "Rémi Denis-Courmont" <remi at remlab.net> writes:
> > Le dimanche 18 novembre 2012 04:14:14, Edward Wang a écrit :
> >> ---
> >> 
> >>  contrib/src/postproc/rules.mak |    4 ++++
> >>  1 files changed, 4 insertions(+), 0 deletions(-)
> > 
> > This does not make sense. HAVE_NEON shall either be undefined/uset or
> > empty/zero when it is disabled, but not both. Please make up your mind.
> > 
> >>  ifdef HAVE_NEON
> >> 
> >> +ifeq ($(HAVE_NEON),1)
> 
> An empty value is equivalent to unset when tested with ifdef.

And thus it makes no sense to have TWO NESTED checks.

-- 
Rémi Denis-Courmont
http://www.remlab.net/