[vlc-devel] [PATCH] Android: add native AudioTrack aout module

[Rémi Denis-Courmont]

Le jeudi 4 octobre 2012 22:18:29, Rafaël Carré a écrit :
> From: Ming Hu <tewilove at gmail.com>
> 
> Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>
> Signed-off-by: Rafaël Carré <funman at videolan.org>
> ---
>  configure.ac                      |   12 ++
>  modules/audio_output/Modules.am   |    1 +
>  modules/audio_output/audiotrack.c |  331
> +++++++++++++++++++++++++++++++++++++ 3 files changed, 344 insertions(+)
>  create mode 100644 modules/audio_output/audiotrack.c
> 
> diff --git a/configure.ac b/configure.ac
> index d2acd93..aee98e5 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -3446,6 +3446,18 @@ if test "${HAVE_ANDROID}" = "1"; then
>  fi
> 
>  dnl
> +dnl  android AudioTrack module
> +dnl
> +AC_ARG_ENABLE(audiotrack,
> +  [  --enable-audiotrack   Android native AudioTrack audio output module
> (default disabled)]) +if test "${enable_audiotrack}" = "yes"; then
> +  if test "${HAVE_ANDROID}" = "1"; then
> +     VLC_ADD_PLUGIN([android_audiotrack])
> +     VLC_ADD_LDFLAGS([android_audiotrack], [-ldl])
> +  fi
> +fi

I would arguee that using HAVE_ANDROID in Modules.am would be simpler, avoid 
build system churn and be just as functional.

Otherwise, I'd prefer AS_IF over if-then in new code.

-- 
Rémi Denis-Courmont
http://www.remlab.net/