[vlc-devel] [vlc-commits] motion: move rotate code into the rotate video filter

[Rémi Denis-Courmont]

Le dimanche 7 octobre 2012 01:11:28, Pierre Ynard a écrit :
> vlc | branch: master | Pierre Ynard <linkfanel at yahoo.fr> | Sun Oct  7
> 00:08:35 2012 +0200| [2bf01e19292929c1ea85dad3677aa749d99a75bd] |
> committer: Pierre Ynard
> 
> motion: move rotate code into the rotate video filter
> 
> Where it belongs. Used with --video-filter rotate --rotate-use-motion

I would avoid branching within a spinning critical section...
It's not even hard in this case.

Also b_motion is superfluous:
    b_motion == (p_motion != NULL)

And then:
    i_angle = ((3600+i_angle/2)%3600);
is the same as:
    i_angle = (i_angle / 2) % 3600;
Though I don't understand why tenth of degrees are used rather than floating 
point.

-- 
Rémi Denis-Courmont
http://www.remlab.net/