[vlc-devel] [PATCH 2/2] Add support for the new Android JellyBean MediaCodec API

[Jean-Baptiste Kempf]

On Mon, Oct 08, 2012 at 12:12:23AM +0300, Martin Storsjö wrote :
> >You know you can use C99, right? ;)
> 
> Right - I'll move the declarations to where they're actually used
> the first time.

It is not mandatory, it was just a tip :)

> >Maybe a more explicit message here?
> 
> I guess this one could be dropped altogether, it's mostly
> interesting during early development of this module.

Then keep it under #ifndef NDEBUG

> >Should this be #define'd or in an enum?
> 
> I could do that, yes. Currently these are final static integers in
> the MediaCodec class, the java version of defines/enums for
> constants. But their value is fixed, and it's easier to just
> redeclare them as defines of our own than to write tedious JNI code
> to get their value.

Clearly, but maybe just defines ?

> >>+        memcpy(bufptr, p_block->p_buffer, size);
> >
> ><mode=av500> memcpy? there is a bug. :) </mode>
> 
> This API is pretty hard to use with direct rendering. Also, this
> particular memcpy is just for the input data, the one where the full
> picture is copied is hidden in the CopyOmxPicture function call. ;P

I know, I just could not resist to invoke the av500 pokemon :)

> Ok, I'll return with an improved version soon. :-)

Thanks. :)

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device