[vlc-devel] [PATCH] libvlc: add language and frame rate to libvlc_media_track_info_t

[Rémi Denis-Courmont]

On Tue, 9 Oct 2012 18:06:29 +0200, Felix Paul Kühne
<fkuehne.videolan at gmail.com> wrote:
>> Sure. There are several conditions though:
>> - You bring an important new feature or a major design fox. 
> This is provided by this patch IMO. This is no major breakthrough, but
it
> adds convenience information to be used by libvlc client applications.

This is self-contradictory.

>> - You update the binary version numbers as appropriate (I do not even
>> know
>> how to do that except on Linux).
> This is missing indeed. On OS X / BSD, it works the same way as on Linux
> btw. For Windows, you responded yourself.

No, I did not.

>> - You remove all the legacy LibVLC stuff that was only left for
backward
>> compatibility.
> I don't think this is within the scope of this patch. This patch adds a
> feature. It's not a lets-remove-all-the-old-cruft-clean-up-patch. It
might
> be a good idea to clean up the code when breaking it anyway, sure, valid
> point, but I don't see how this should be a requirement for adding a
> feature. it's not like that we removed VCD support to make room for BR
to
> give a bad analogy.

It's not in scope of this patch. It's in scope of this patch's patch
series. You don't get to dump your minor feature and break the interface
and then wait for other developers to clean up after you. The one that
breaks the library interface gets to pay the price.

>> - You update the documentation.
> Valid point. This should be done so libvlc user's can benefit from the
new
> functionality.
> 
>> - You take adequate measures to avoid the same problem occurring again
>> with the same family of functions (i.e. next time some bit of track
info
>> is
>> added).
> Do you really think this is needed?

Yes, I do.

This patch proves the need to begin with.

-- 
Rémi Denis-Courmont
Sent from my collocated server