[vlc-devel] [vlc-commits] Android: thread->killable does not need to be atomic

Rafaël Carré funman at videolan.org
Sat Oct 13 13:39:39 CEST 2012


Le 13/10/2012 13:38, Rémi Denis-Courmont a écrit :
> Le samedi 13 octobre 2012 13:42:53, Rafaël Carré a écrit :
>>>      int oldstate = vlc_atomic_get(&thread->killable);
>>
>> You forgot this one
>>
>>> -    vlc_atomic_set(&thread->killable, false);
>>> +    thread->killable = false;
> 
> Unfortunately, I do not have an adequate Android development and testing 
> environment at home, and probably will not any time soon.

In this case please next time send your patches on the list so they can
be tested.

Also getting the NDK from google is not that hard..



More information about the vlc-devel mailing list