[vlc-devel] [PATCH 2/3] v4l2: make VBI mode work with UserPtr and ReadStream mode

Devin Heitmueller dheitmueller at kernellabs.com
Sun Oct 21 22:44:08 CEST 2012


On Sun, Oct 21, 2012 at 4:27 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On 21 Oct, Devin Heitmueller wrote :
>> +                int i;
>> +                for (i = 0; i < 4; i++)
>
> You know that VLC accepts C99 ? :) (Absolutely not mandatory)

Yeah, the declaration of the variable in the top of the for loop was
something I knew could be a portability issue, but I didn't bother to
check what VLC's stance was on compiler support.

I can submit an additional patch to the series to fix that, but I
would prefer to not have to rebase my git tree to generate an updated
patch so if you could please apply as-is for now, that would be great.

Thanks,

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com



More information about the vlc-devel mailing list