[vlc-devel] [PATCH 0/2] Video4Linux VBI feedback fixes

Rémi Denis-Courmont remi at remlab.net
Mon Oct 22 10:55:09 CEST 2012

   Hey Devin,

I have not had time to review the patches yet. Nevertheless, it is
recommended to amend/squash feedback fixes into existing patches and
repost. Otherwise it becomes difficult for reviewers to track what has
already been fixed and what has not. That is very much like the Linux
kernel practices you should be familiar with. 

On Sun, 21 Oct 2012 16:52:46 -0400, Devin Heitmueller
<dheitmueller at kernellabs.com> wrote:
> This patch series fixes a coding style issue and an incorrect
> copyright year (both issues pointed out by Jean-Baptiste Kempf)
> This patch series depends on the patch series sent earlier today
> for Video4Linux VBI device support.
> Devin Heitmueller (2):
>   v4l2: fix copyright date on vbi.c
>   v4l2: Change to C99 style of for loop incrementer declaration
>  modules/access/v4l2/demux.c |   12 ++++--------
>  modules/access/v4l2/vbi.c   |    2 +-
>  2 files changed, 5 insertions(+), 9 deletions(-)

Rémi Denis-Courmont
Sent from my collocated server

More information about the vlc-devel mailing list