[vlc-devel] fdkaac based audio encoder module (final version in git format)

[Sergio M. Ammirata, Ph.D.]

I made the changes for CLOCK_FREQ. As far as using VLC_TS_INVALID instead
of 0, it is not really appropriate in this case as that code is only a
check for an initial condition/value setup in the open function.

As far as the double vs. date_t/friends, I have done extensive testing and
the code is accurate and without rounding errors the way it is (down to
the microsecond). I would not want to go back to printing out and testing
all the scenarios of timestamps to make sure they are accurate with date_t.

Sergio

On 10/25/12 11:21 AM, "Rémi Denis-Courmont" <remi at remlab.net> wrote:

>Le jeudi 25 octobre 2012 18:17:52, Sergio M. Ammirata, Ph.D. a écrit :
>> Here is the final version with all the discussed changes. I could not
>> eliminate the extra variables as they were double pointers.
>
>You should use VLC_TS_INVALID instead of 0 for unspecified timestamp, and
>CLOCK_FREQ instead of 1000000.
>
>Furthermore, I don't think double precision computation is a good idea
>for 
>timestamps. You should probably use date_t and friends instead, to avoid
>rounding errors.
>
>-- 
>Rémi Denis-Courmont
>http://www.remlab.net/
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>http://mailman.videolan.org/listinfo/vlc-devel