[vlc-devel] fdkaac based audio encoder module (final version in git format)

[Sergio M. Ammirata, Ph.D.]

Here it is. Hopefully the last one.

On 10/25/12 11:26 AM, "Jean-Baptiste Kempf" <jb at videolan.org> wrote:

>On 25 Oct, Sergio M. Ammirata, Ph.D. wrote :
>> Here is the final version with all the discussed changes. I could not
>> eliminate the extra variables as they were double pointers.
>
>> +PKG_ENABLE_MODULES_VLC([FDKAAC], [], [fdk-aac], [FDK-AAC encoder],
>>[auto])
>
>Please, disable it by default.
>
>> +#define PROFILE_AAC_LC 2
>> +#define PROFILE_AAC_HE 5
>> +#define PROFILE_AAC_HE_v2 29
>> +#define PROFILE_AAC_LD 23
>> +#define PROFILE_AAC_ELD 39
>
>This is not defined in any headers? I am surprised...

They only exist in a private header inside the library.

>
>> +struct encoder_sys_t
>> +{
>> +    double d_compression_ratio;
>> +    mtime_t i_pts_last;
>> +    int i_aot;
>> +    int i_vbr;
>> +    int i_signaling;
>> +    int i_encoderdelay;
>> +    int i_frame_size;
>> +    int i_maxoutputsize;
>> +    HANDLE_AACENCODER handle;
>> +    bool b_afterburner;
>> +    bool b_eld_sbr;
>> +};
>
>Please add comments, some are not _that_ straightforward, like aot

Done

>
>> +        i_profile = PROFILE_AAC_HE_v2;
>> +    }   
>
>trailing space.

Done

>
>> +    msg_Info(p_enc, "Initializing AAC Encoder, %i channels",
>>p_enc->fmt_in.audio.i_channels);
>
>Put this after the switch, in case of fail...

Done

>
>> +        msg_Err(p_enc, "Unable to set the ADTS transmux: %s",
>>aac_get_errorstring(erraac));
>> +        goto error;
>> +    }    
>
>And again.

Done

>
>Best regards,
>
>-- 
>Jean-Baptiste Kempf
>http://www.jbkempf.com/ - +33 672 704 734
>Sent from my Electronic Device
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>http://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-a-new-aac-audio-encoder-module-based-on-the-fdka.patch
Type: application/octet-stream
Size: 24080 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20121025/50005f07/attachment.obj>