[vlc-devel] [PATCH] Add new API to libvlc for persistent equalizer settings.

[Mark Lee]

Hello,

On 2 September 2012 11:23, Rémi Denis-Courmont <remi at remlab.net> wrote:

> Le dimanche 2 septembre 2012 12:06:32, Mark Lee a écrit :
> > Hello,
> >
> > On 1 September 2012 09:21, Rémi Denis-Courmont <remi at remlab.net> wrote:
> > > > Any comments or other ideas?
> > >
> > > You should probably set a variable on the media player object instead.
> >
> > Thanks for this suggestion.
> >
> > This approach actually makes the whole patch simpler.
>
> Not really. You still ought to set the same value on the aout object when
> it
> exists. There are a lot of examples in Libvlc already, related to aout or
> vout.
>
> I think maybe I misunderstood your original suggestion.

The latest version of the patch does set values on the aout, but it uses an
additional variable on the media player to track whether or not the
equalizer should automatically be enabled when playing new media. This was
to solve the last issue I had where I found that if you enable the filter
before you start playback it saves the filter string to config and restores
it correctly on new media; but if you enable the filter after you start
playback it saves the filter string to the aout instead, ultimately failing
to automatically set the equalizer if you stop/start or play new media
(since the aout disappears and you get a new one without the filter string).

When I looked for other examples, I noted that the video adjust settings
are not automatically restored when stopping and playing media, or when
playing new media - you have to manually re-apply them each time. For the
equalizer I really thought it more useful for it to automatically apply the
previous settings.

Anyway, the latest version of the patch (posted a few days ago) is right
now my best effort at this. If it's still not right I am unsure where to go
next.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120904/04c03cf7/attachment.html>