[vlc-devel] [PATCH] fixed GDI leaks

Rafaël Carré funman at videolan.org
Mon Sep 10 14:33:54 CEST 2012


Le 08/09/2012 06:17, Sergey Radionov a écrit :
> 2012/9/8 Rafaël Carré <funman at videolan.org>:
>> Hello,
>>
>> Le 2012-09-07 16:39, Sergey Radionov a écrit :
>>> ---
>>>  common/win32_fullscreen.h |   11 +++++++++++
>>>  1 files changed, 11 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/common/win32_fullscreen.h b/common/win32_fullscreen.h
>>> index d60800d..c30cb6b 100644
>>> --- a/common/win32_fullscreen.h
>>> +++ b/common/win32_fullscreen.h
>>> @@ -39,6 +39,17 @@ struct VLCViewResources
>>>           hPlayBitmap(0), hVolumeBitmap(0), hVolumeMutedBitmap(0),
>>>           hBackgroundIcon(0)
>>>      {};
>>> +    ~VLCViewResources()
>>> +    {
>>> +        if( hNewMessageBitmap )   DeleteObject( hNewMessageBitmap );
>>
>> That one is unused no? I don't see where it is assigned.
> yes, but it can be assigned.
> 
> It's for: http://git.videolan.org/?p=npapi-vlc.git;a=blob;f=common/win32_fullscreen.cpp;hb=HEAD#l435
> 
> but, in current version this feature is not used.

Thanks, applied.



More information about the vlc-devel mailing list