[vlc-devel] [PATCH] mpeg4audio packetizer: 0 for channel config in ADTS header

[XilasZ]

As said on IRC, i missed the fact that Mpeg4GAProgramConfigElement is
called only for LOAS. there's nothing for ADTS.
So the patch is wrong, code must be added to read channel config in case of
adts.


On Tue, Sep 11, 2012 at 4:26 PM, Rafaël Carré <funman at videolan.org> wrote:

> Hello,
>
> Le 11/09/2012 14:29, XilasZ a écrit :
> > A value of 0 for channel config in ADTS header lead to "Invalid ADTS
> > header", preventing sound playback on some streams.
> >
> > But it is a valid value (cf
> http://wiki.multimedia.cx/index.php?title=ADTS).
> > 0 means that channel config is not specified in the header, but in
> another
> > structure, following the header.
>
> Nice work!
>
> Does it fix a bug in trac?
>
> If yes please add "Close #xxxx" to the log so when committed the bug
> will be closed automatically.
>
> > Besides, in mpeg4audio.c, in case of 0, Mpeg4GAProgramConfigElement is
> > called to find the channel config from this structure.
>
> That function still has "/* TODO compute channels count ? */" though,
> should we fix that TODO before committing that patch?
>
> > So the check on the header is wrong, this patch fix it.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120911/19a9e466/attachment.html>