[vlc-devel] [PATCH] Add Smooth Streaming module

[Jean-Baptiste Kempf]

On Wed, Sep 12, 2012 at 11:28:54AM +0200, Frédéric Yhuel wrote :
> +    //msg_Dbg( s, "bw is %"PRIu64"", *bandwidth );

Maybe add it in debug versions

> +static int get_new_chunks( stream_t *s, chunk_t *ck )
> +{
> +    assert( type == ATOM_moof );

Are you sure those should be asserts ? And similar checks? If the server
is wrong, what happens?

> +    char *url = ConstructUrl( sms->url_template, p_sys->base_url,
> +                                  qlevel->Bitrate, chunk->start_time );

No checking if url is NULL ?

> +    add_bool( "smooth-disable-audio", false, DA_TEXT, DA_LONGTEXT, false )

Same question as before :)

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device