[vlc-devel] Fwd: [PATCH] avi: Tidy the palette handling bit.

Frode Tennebø frode at tennebo.com
Fri Sep 14 08:08:24 CEST 2012


On 14 September 2012 00:10, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On Thu, Sep 13, 2012 at 09:48:09PM +0200, Frode Tennebř wrote :
>> I'm resending this as it was never accepted.
>
> I did not apply it, because the bug was not fixed, notably on Windows.

It might quite possibly be two separete bugs, where my initial patch
fixed the first bug which had to do with the interpretation of the
BITMAPINFO structure.  My second patch was only to tidy the handling
of that intrepretation.

The second bug, which is not apparent on Linux - at least not in the
same way - I have no cure for as I'm not able to reproduce.

>> After 2.0.2 was released I became aware that paletted avis is still a
>> problem for Windows.  I'm not sure how to handle that as the patches
>> fixes this for Linux.  What differs the Windows code path and/or build
>> chain from Linux?
>
> The Windows path is the same for demuxing AVIs.

Clearly, something is different.  When I was investigating this on
Linux I discovered that configuring with --disable--swscale produced
all an all black visual as it does on Windows.  Could something like
this be a problem for the Windows build?

 -Frode



More information about the vlc-devel mailing list