[vlc-devel] [PATCH 1/2] demux/mp4: Add fragmented MP4 support

Frédéric Yhuel yhuelf at gmail.com
Thu Sep 20 19:14:38 CEST 2012


On Thu, Sep 20, 2012 at 5:23 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On Wed, Sep 19, 2012 at 05:14:41PM +0200, Frédéric Yhuel wrote :
>> -    p_root->i_size = stream_Size( s );
>> +    p_root->i_size = INT64_MAX; /* could be live streaming */
>
> Why not -1 or something else?
>

It seems like 0 means infinite size (at least in nefrir's mind), if
you look at the code of MP4_NextBox().

So I can set it to 0, so that it is consistent with the rest, but some
tests must be skipped.

I provide here a new patch, and the diff with the previous one.

-- 
Frédéric
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libmp4-handle-the-case-where-size-of-root-s-containe.patch
Type: application/octet-stream
Size: 3149 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120920/e605b392/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-demux-mp4-Add-fragmented-MP4-support.patch
Type: application/octet-stream
Size: 48937 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120920/e605b392/attachment-0001.obj>


More information about the vlc-devel mailing list