[vlc-devel] UYVY incompatible with the transform filter

Felix Paul Kühne fkuehne.videolan at gmail.com
Sat Sep 29 23:13:36 CEST 2012


we had a bug report on the forum recently that the transform filter refuses UYVY content, so I investigated it and found that the filter automatically denies this chroma format since it is a "weird packed format".

At first, I have no idea what that is supposed to be. Secondly, applying the following diffs enables the filter just nicely with any visible (note that I'm red-green colorblind *cough*) artifacts.

Any comments or ideas?



diff --git a/modules/video_filter/transform.c b/modules/video_filter/transform.c
index 5c2f1d1..b9919c1 100644
--- a/modules/video_filter/transform.c
+++ b/modules/video_filter/transform.c
@@ -347,7 +347,6 @@ static int Open(vlc_object_t *object)
     /* Deal with weird packed formats */
     switch (src->i_chroma) {
-        case VLC_CODEC_UYVY:
         case VLC_CODEC_VYUY:
             if (dsc_is_rotated(dsc)) {
                 msg_Err(filter, "Format rotation not possible (chroma %4.4s)",
@@ -355,6 +354,7 @@ static int Open(vlc_object_t *object)
                 goto error;
             /* fallthrough */
+        case VLC_CODEC_UYVY:
         case VLC_CODEC_YUYV:
         case VLC_CODEC_YVYU:
             sys->plane = dsc->yuyv; /* 32-bits, not 16-bits! */

More information about the vlc-devel mailing list