[vlc-devel] [PATCH] Subsync: added an easier way to sync subtitles

[Pascal Thomet]

Hi Zoran,


Thanks for your feedback, and for your interesting suggestions.
I will work on those modifications tonight, and find a better way to
send the patch.

Regards from Paris,

Pascal

On Mon, Apr 8, 2013 at 10:31 AM, Zoran Turalija
<zoran.turalija at gmail.com> wrote:
> On Sun, Apr 07, 2013 at 10:13:37PM +0200, Pascal Thomet wrote:
>> From f09dbbc4d8fb5c7f88e9526d043a85b0385632f8 Mon Sep 17 00:00:00 2001
>> From: Pascal Thomet <pthomet at gmail.com>
>> Date: Sun, 7 Apr 2013 17:57:45 +0200
>> Subject: [PATCH] Subsync: added an easier way to sync subtitles
>>
>> Added the following shortcuts (and made them configurable):
>> - Ctrl-H: sets a timestamp bookmark on the audio
>> - Ctrl-J: sets a timestamp bookmark on the subtitle
>> - Ctrl-K: corrects the delay between both bookmarks
>>
>> Notes:
>> - This patch changes adds hotkeys to the control GUI. I suspect this kind of
>> change may require a more
>>   thorough analysis before being accepted.
>> - See http://forum.videolan.org/viewtopic.php?f=7&t=109641 for an illustration
>> of a possible use
>>   (I changed the wordings a little bit in the source)
>> - This is the kind of feature I'd like to have when my subtitles are out of
>> sync,
>>   and I want a quick way of solving it (without having to download/install a
>> dedicated
>>   3rd party software)
>> - Current implementation uses a static variable at hotkeys.c:125 (room for
>> improvement, i guess)
>
> Hi Pascal, nice idea.
>
> It is better to use modifier SHIFT insted of CTRL, as suggested and explained
> in comment just before "Non Mac OS X" section of keys definitions in file
> src/libvlc-module.c.
>
> So, in this case I would recommend:
> - Shift-H
> - Shift-J
> - Shift-K
>
> And while you're at it, you can add these same definitions for "Non Mac OS X"
> under that section.
>
> Also, from usability standpoint, it would be feasible to introduce something
> like ACTIONID_SUBSYNC_RESET because we humans are not error prone, and it can
> come in handy to reset subtitle offset without lifting fingers of the keyboard,
> grabbing mouse and clicking through menu just for that.
>
> You can define hotkey for that like Ctrl-Shift-K.
>
> I hope to see this patch mainlined eventually.
>
> BTW, looks like your patch is mangled due to html mail formatting. Try sending
> patches as plain text.
>
> --
> Kind regards,
> Zoran Turalija
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel