[vlc-devel] [vlc-commits] Qt: add events extender

[Rémi Denis-Courmont]

Le vendredi 5 avril 2013 01:29:54, Francois Cartegnie a écrit :
> vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Thu Apr  4
> 23:20:42 2013 +0200| [c38081e5680bb6c35c65ea8de3dfbd7c4e484586] |
> committer: Francois Cartegnie
> 
> Qt: add events extender

This seems to be dead code. I am not sure what you are trying to achieve, but 
I will remind you that:

1/ There is no point in pushing yet unused code. Git always you to branch and 
push the set of consistent patches at once.

2/ Discriminating mouse button presses is maybe not very intuitive and hence 
not very usable. (I can see the point for a first person shooter but not really 
for a media player.)

3/ The X11 does not permit more than one receiver for mouse button (and 
keyboard) events. And the current architectural work split of the VLC video 
output requires the vout display object to catch mouse clicks. Until this role 
is reassigned to the vout window object, the Qt interface _cannot_ catch mouse 
events within the video widget area.
Such a change would be advantageous w.r.t. Qt5 and EGL support. But the 
development work involved spans across the video output core, all X11 video 
outputs and all X11 video window providers at least...

-- 
Rémi Denis-Courmont
http://www.remlab.net/