[vlc-devel] jack output: patch for #8126

Rémi Denis-Courmont remi at remlab.net
Thu Apr 11 17:29:41 CEST 2013

This looks wrong:

+        p_block->i_nb_samples -= bytes / sizeof(jack_sample_t);

But of course since you don't use the samples count, you could remove the line 

I do not understand why you keep track of bytes_per_frame since it equals 4 * 
channels. In particular, this case looks totally bogus/impossible:

+    if( p_sys->bytes_per_frame == 0 )
+        return -1;

Rémi Denis-Courmont

More information about the vlc-devel mailing list