[vlc-devel] [PATCH] Qt4: minor grammar and orthography fixes

Wed Apr 17 15:18:48 CEST 2013

Why adding those commas, before the "and"? I don't see any possible
confusion in the list, is there?

On 16 Apr, Edward Wang wrote :
> ---
>  modules/gui/qt4/dialogs/help.cpp |    2 +-
>  modules/gui/qt4/ui/about.ui      |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/gui/qt4/dialogs/help.cpp b/modules/gui/qt4/dialogs/help.cpp
> index a281afd..a4c6c44 100644
> --- a/modules/gui/qt4/dialogs/help.cpp
> +++ b/modules/gui/qt4/dialogs/help.cpp
> @@ -141,7 +141,7 @@ bool AboutDialog::eventFilter(QObject *obj, QEvent *event)
>              if( !b_advanced )
>              {
>                  ui.version->setText(qfu( VLC_CompileBy() )+ "@" + qfu( VLC_CompileHost() )
> -                    + __DATE__ + " " +__TIME__);
> +                    + " " + qtr("on") + " " + __DATE__ + " " +__TIME__);
>                  b_advanced = true;
>              }
>              else
> diff --git a/modules/gui/qt4/ui/about.ui b/modules/gui/qt4/ui/about.ui
> index 47b8163..1f3afce 100644
> --- a/modules/gui/qt4/ui/about.ui
> +++ b/modules/gui/qt4/ui/about.ui
> @@ -114,7 +114,7 @@ background-color: rgb(245, 245, 245);</string>
>               <string notr="true">padding-right: 20px;</string>
>              </property>
>              <property name="text">
> -             <string><html><head/><body><p>VLC media player is a free and open source media player, encoder and streamer made by the volunteers of the <a href="http://www.videolan.org/"><span style=" text-decoration: underline; color:#0057ae;">VideoLAN</span></a> community.</p><p>VLC uses its internal codecs and works on essentially every popular platform and can read almost every files, CDs, DVDs, network streams, capture cards and other media formats!</p><p><a href="http://www.videolan.org/contribute/"><span style=" text-decoration: underline; color:#0057ae;">Help and join us!</span></a></p></body></html></string>
> +             <string><html><head/><body><p>VLC media player is a free and open source media player, encoder, and streamer made by the volunteers of the <a href="http://www.videolan.org/"><span style=" text-decoration: underline; color:#0057ae;">VideoLAN</span></a> community.</p><p>VLC uses its internal codecs, works on essentially every popular platform, and can read almost all files, CDs, DVDs, network streams, capture cards and other media formats!</p><p><a href="http://www.videolan.org/contribute/"><span style=" text-decoration: underline; color:#0057ae;">Help and join us!</span></a></p></body></html></string>
>              </property>
>              <property name="alignment">
>               <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop</set>
> -- 
> 1.7.5.4
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel

-- 
Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device