[vlc-devel] [PATCH 2/2] hotkeys: When no audio is active, inform user timestamp is based on video.

Zoran Turalija zoran.turalija at gmail.com
Mon Apr 22 13:10:08 CEST 2013


On Mon, Apr 22, 2013 at 11:26:04AM +0200, Jean-Baptiste Kempf wrote:
> On 22 Apr, Zoran Turalija wrote :
> > On Mon, Apr 22, 2013 at 10:43:07AM +0200, Jean-Baptiste Kempf wrote:
> > > On 22 Apr, Zoran Turalija wrote :
> > > > Nonsense. You should review patch better. There is nothing ridiculous in it.
> > > 
> > > Yes, it is ridiculous. The user care about functionnality, not whether
> > > this was synced to audio or video track.
> > 
> > No, users care about quality.
> 
> Right.
> 
> > But that is aside the point. Your point is that it is for "my" debbuging
> > dialog. And the fact is: it is not for "me" nor it is for "debug", it is for
> > OSD dialog.
> 
> OSD does not need such info to be displayed. Look at the rest of the OSD
> display.

That is valid point.

Thanks for review.

-- 
Kind regards,
Zoran Turalija



More information about the vlc-devel mailing list