[vlc-devel] [PATCH 4/4] Strings: Use BluRay without -, remove identical (except .) longtext

[Felix Paul Kühne]

Hello Christoph,

one remark on this patch.

On 26.04.2013, at 11:31, Christoph Miebach <christoph.miebach at web.de> wrote:

> diff --git a/modules/gui/macosx/playlist.m b/modules/gui/macosx/playlist.m
> index c4360b8..734b82d 100644
> --- a/modules/gui/macosx/playlist.m
> +++ b/modules/gui/macosx/playlist.m
> @@ -504,7 +504,7 @@
>     [o_mi_recursive_expand setTitle: _NS("Expand Node")];
>     [o_mi_selectall setTitle: _NS("Select All")];
>     [o_mi_info setTitle: _NS("Media Information...")];
> -    [o_mi_dl_cover_art setTitle: _NS("Download Cover Art")];
> +    [o_mi_dl_cover_art setTitle: _NS("Download cover art")];
>     [o_mi_preparse setTitle: _NS("Fetch Meta Data")];
>     [o_mi_revealInFinder setTitle: _NS("Reveal in Finder")];
>     [o_mm_mi_revealInFinder setTitle: _NS("Reveal in Finder")];

Regrettably, this looks wrong to me due to the widespread use of capitalized strings throughout the OSX menus.

Rest is fine.

Cheers,

Felix