[vlc-devel] [PATCHES] -- fix marquee failing to format input-dependent text ($N, $...)

brezhoneg1 brezhoneg1 at yahoo.fr
Sat Apr 27 13:51:40 CEST 2013

Le 27/04/2013 07:48, Rémi Denis-Courmont a écrit :
> Le samedi 27 avril 2013 03:21:51, brezhoneg1 a écrit :
>> Please, review it and tell me if you see it as an
>> acceptable fix for the time being ?
> Holding an input thread with the input resource makes absolutely no sense. An
> input thread is not reusable - across input items (and even if it were, there
> is no point reusing it).

Yes, I know it's a hack, but I wouln't say "it makes absolutely no 
sense", because it does fix an issue that has been around for a very 
long time.

  As a matter of fact, the input object is often needed by a lot of 
other objects. Some of them keep a so-called "weak" reference to it 
(access, demux, decoder, ...).  Others don't.  Filters like marquee are 
so far away from the input that they have lost complete track of it if 
it ever existed in the first place. This input lookup is a real issue 
that a more general design needs to address.

This patch just tries to find a convenient and unintrusive place to 
retrieve the input for the short term. The resource manager happens to 
keep an updated "weak" reference to it, and unlike the input object, be 
easily reachable for the marquee object through the inheritance 
mechanism in today's dependencies of objects. So why not use it in 
str_format instead of the input provided by the playlist which is a lot 
more restrictive ?

Anyway, it would be good that the next vlc be shipped without these 
marquee regression (for the playlist) and limitation (for libvlc). With 
or without this lame patch or with an updated version since I realized 
there is a prototype issue that needs to be corrected.


More information about the vlc-devel mailing list