[vlc-devel] [PATCH] Kill many trailing :

[Felix Paul Kühne]

Hello,

On 28.04.2013, at 16:48, Christoph Miebach <christoph.miebach at web.de> wrote:

> modules/gui/macosx/AudioEffects.m                     |  8 ++++----
> modules/gui/macosx/ConvertAndSave.m                   |  4 ++--
> modules/gui/macosx/MainWindow.m                       |  4 ++--
> modules/gui/macosx/TrackSynchronization.m             |  2 +-
> modules/gui/macosx/VideoEffects.m                     |  4 ++--
> modules/gui/macosx/open.m                             |  4 ++--
> modules/gui/macosx/playlist.m                         |  2 +-
> modules/gui/macosx/simple_prefs.m                     |  4 ++--

I put colons there for a reason, so I don't really understand the intend of your patch.

If you want to drop duplicate strings with and without colon, the correct work-around would be to do a [NSString stringWithFormat:@"%@:", _NS("string without colons")] instead of just removing those. There are plenty of examples doing this in the macosx interface including patches by me submitted last week.

Best regards,

Felix