[vlc-devel] [PATCH 2/4] Increase the avformat mux buffer size to 10 MB.

[Georgi Chorbadzhiyski]

Around 08/15/2013 01:10 AM, Steinar H. Gunderson scribbled:
> The previous value, 32 kB, causes formats like WebM to overflow
> and split the blocks, which has negative consequences for streaming.
> We're unlikely to have a memory crunch in this area, so increase it
> to something generous.
> ---
>  modules/demux/avformat/mux.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/demux/avformat/mux.c b/modules/demux/avformat/mux.c
> index 90e17dc..f8208a6 100644
> --- a/modules/demux/avformat/mux.c
> +++ b/modules/demux/avformat/mux.c
> @@ -115,7 +115,7 @@ int OpenMux( vlc_object_t *p_this )
>          strcpy( p_sys->oc->filename, p_mux->p_access->psz_path );
>  
>      /* Create I/O wrapper */
> -    p_sys->io_buffer_size = 32768;  /* FIXME */
> +    p_sys->io_buffer_size = 10 << 20;  /* FIXME */

Nit, IMHO 10 * (1024 ^ 2) is more readable than 10 << 20.

>      p_sys->io_buffer = malloc( p_sys->io_buffer_size );
>  
>      bool b_can_seek;
> 

-- 
Georgi Chorbadzhiyski
http://github.com/gfto/
http://georgi.unixsol.org/