[vlc-devel] [PATCH] network: export SO_RCVBUF & SR_SNDBUF as config options

[Tzu-Jung Lee]

Hi Rémi,

On Thu, Aug 15, 2013 at 11:21 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le mardi 13 août 2013 01:31:00 Tzu-Jung Lee a écrit :
>> This patch allows user to overrite default values set by VLC on our
>> Linux system, though I haven't managed to build a Windows version
>> and give it a try.
>

> This won't really fix the problem. Users will not know that they need to change
> the VLC settings. And those who do know will complain that it does not work,
> because they will omit to raise the limits in /proc or the registry or
> whatever...

> If the limits are wrong for some input or some output, I think that specific
> input or output should select a better default value.
> Increasing the buffer
> sizes for all sockets does not look like such a great idea to me.

I certainly agree your points but that doesn't conflict what the patch
proposed at all.

The values under /proc or registry are system-wise default and max values.
The setsocketopt() in VLC overwrites the 'MAX' one, which means if the
512KB is not
enough for specific input/output, users can't do anything even they
know the buffer size
is the key here.

So we can keep the current default 512 KB in VLC, and allow user to
overwrite this value
when they know what values work for them.

Thanks.

Roy