[vlc-devel] [vlc-commits] src: Fix for Mac OS X filesystem filename encoding
Felix Paul Kühne
fkuehne.videolan at gmail.com
Thu Aug 22 16:06:43 CEST 2013
On 22.08.2013, at 15:28, Rémi Denis-Courmont <remi at remlab.net> wrote:
> On Thu, 22 Aug 2013 12:19:14 +0200 (CEST), git at videolan.org (Naohiro
> KORIYAMA) wrote:
>> vlc | branch: master | Naohiro KORIYAMA <nkoriyama at gmail.com> | Tue Aug
>> 11:34:07 2012 +0900| [0970461e97dc0dbd54006c7e7a9da80990f946a0] |
>> committer: Felix Paul Kühne
>> src: Fix for Mac OS X filesystem filename encoding
> What is your excuse for pushing this obvious crap without reviewing it?
Patch looked ok for me before having my first coffee, so review on this mailing-list may have been a good idea indeed. I'll ask Naohiro to rework it.
> What is your excuse for breaking the test suite?
None as I did not run it to be honest. Should I do so instead relying on the buildbot? Yeah, indeed I should. Point taken.
More information about the vlc-devel