[vlc-devel] [PATCH 1/4] avformat mux: Propagate seekable status into avformat.

[Steinar H. Gunderson]

On Sun, Aug 25, 2013 at 12:41:04PM +0300, Rémi Denis-Courmont wrote:
>> +#include <sys/types.h>
>> +#include <sys/stat.h>
>> +#include <unistd.h>
> Not that I really care but is this available on all platforms? (OS/2?)

OS/2 I have no idea about. <unistd.h> I see is already included conditionally
down there, so I could remove it. I assume VLC doesn't typically use autoconf
macros (ie., HAVE_SYS_STAT_H) for this?

>> +    bool b_can_seek;
>> +    if( sout_AccessOutControl( p_mux->p_access, ACCESS_OUT_CAN_SEEK,
>> &b_can_seek ) )
>> +        b_can_seek = false;
>>      p_sys->io = avio_alloc_context(
>>          p_sys->io_buffer, p_sys->io_buffer_size,
>> -        1, p_mux, NULL, IOWrite, IOSeek );
>> +        1, p_mux, NULL, IOWrite, b_can_seek ? IOSeek : NULL );
> This is an undefined conditional if the access output is not "file".

Why is it undefined? There's a line there setting b_can_seek = false if the
call fails.

/* Steinar */
-- 
Homepage: http://www.sesse.net/