[vlc-devel] [PATCH 1/2] lua: add a guess_encoding function to convert Latin1 to UTF8

[Rémi Denis-Courmont]

On Tue, 27 Aug 2013 15:57:33 +0200, Ludovic Fauvet <etix at videolan.org>
wrote:
> On 08/27/2013 03:49 PM, Rémi Denis-Courmont wrote:
>> On Tue, 27 Aug 2013 15:15:52 +0200, Ludovic Fauvet <etix at videolan.org>
>> wrote:
>>> ---
>>>  modules/lua/libs/strings.c | 17 +++++++++++++++++
>>>  1 file changed, 17 insertions(+)
>> 
>> There is no point in doing this. from_charset already provides all
that's
>> needed (and is much sounder architecturally).
> 
> The from_charset function doesn't provide feedback nor failure if the
> input string doesn't match the expected encoding

That's not true. It returns an empty string on error, which is clearly
different from success. Feel free to change it to return a proper error or
nil.

> for strings already encoded in UTF8.

The only valid UTF-8 string that can be represented by the empty string is
the empty string.

> Or did I miss something?

-- 
Rémi Denis-Courmont
Sent from my collocated server