[vlc-devel] [PATCH 1/2] lua: add a guess_encoding function to convert Latin1 to UTF8

[Ludovic Fauvet]

On 08/27/2013 04:27 PM, Rémi Denis-Courmont wrote:
> On Tue, 27 Aug 2013 16:14:55 +0200, Ludovic Fauvet <etix at videolan.org>
> wrote:
>>> That's not true. It returns an empty string on error, which is clearly
>>> different from success. Feel free to change it to return a proper error
>>> or nil.
>>
>> Sorry but you're wrong.
> 
> No. You are. You can RTFS if you do not believe me.

You should be kidding! Right?

>> Using the following piece of code:
>> src = vlc.strings.from_charset("ISO_8859-1", src)
>>
>> and the following UTF8 encoded input string:
>> Le Lac des Cygnes (Piotr Ilitch Tchaïkovsky)
>>
>> It gives me the following result:
>> Le Lac des Cygnes (Piotr Ilitch Tchaïkovsky)
> 
> Yes, and so what?

You don't see what's wrong with it? Because I do.

>> Where's my empty string?
> 
> There was no error, and there is no empty string. This is irrelevant.

This review is a complete nonsense. Can't you just admit that your
assumptions were wrong so we can actually move forward and find the
*best* way to fix this issue or are you going to continue arguing that
there is no issue?

-- 
Ludovic Fauvet
www.videolan.org