[vlc-devel] [vlc-commits] Qt: toAscii has been deprecated

[Rémi Denis-Courmont]

On Wed, 28 Aug 2013 13:39:30 +0200 (CEST), git at videolan.org (Jean-Baptiste
Kempf) wrote:
> vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Wed Aug
28
> 13:35:27 2013 +0200| [8332a26a12947f24a3d2219d3265062840b2020f] |
> committer: Jean-Baptiste Kempf
> 
> Qt: toAscii has been deprecated
> 
> Ref #8532
> 
>>
http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=8332a26a12947f24a3d2219d3265062840b2020f
> ---
> 
>  modules/gui/qt4/components/playlist/playlist_model.cpp |    4 ++--
>  modules/gui/qt4/components/playlist/standardpanel.cpp  |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/modules/gui/qt4/components/playlist/playlist_model.cpp
> b/modules/gui/qt4/components/playlist/playlist_model.cpp
> index 2e09c27..0c7e762 100644
> --- a/modules/gui/qt4/components/playlist/playlist_model.cpp
> +++ b/modules/gui/qt4/components/playlist/playlist_model.cpp
> @@ -1007,7 +1007,7 @@ bool PLModel::action( QAction *action, const
> QModelIndexList &indexes )
>  
>      case ACTION_ENQUEUEFILE:
>          foreach( const QString &uri, a.uris )
> -            playlist_Add( THEPL, uri.toAscii().constData(),
> +            playlist_Add( THEPL, uri.toLatin1().constData(),

Minding that Latin-1 is a superset of ASCII, this is functionally correct.
But I think toUtf8() would be far less prone to misinterpretation by
someone reading the code later.

-- 
Rémi Denis-Courmont
Sent from my collocated server