[vlc-devel] [PATCH] Set GCRYPT_NO_DEPRECATED to suppress libgcrypt deprecation warnings

[Rémi Denis-Courmont]

On Tue,  3 Dec 2013 16:20:41 +0400, Maxim Bublis <b at codemonkey.ru> wrote:
> ---
>  configure.ac | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 5f7ed24..c1e45e4 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -3958,6 +3958,7 @@ AS_IF([test "${enable_libgcrypt}" != "no"], [
>      libgcrypt-config --version >/dev/null || \
>          AC_MSG_ERROR([gcrypt.h present but libgcrypt-config could not
be
>          found])
>      AC_CHECK_LIB(gcrypt, gcry_control, [
> +      AC_DEFINE([GCRYPT_NO_DEPRECATED], [1], [Disable deprecated
> libgcrypt definitions])

Suppressing deprecated functions blindly is a bad idea, IMHO. If some
future version of gcrypt deprecates a function VLC currently uses, this
ends up breaking the build for no good reasons.

>        have_libgcrypt="yes"
>        GCRYPT_CFLAGS="`libgcrypt-config --cflags`"
>        GCRYPT_LIBS="`libgcrypt-config --libs`"

-- 
Rémi Denis-Courmont
Sent from my collocated server