[vlc-devel] [PATCHv10] dcp: Creation of access-demux module for DCP

Nicolas Bertrand nicoinattendu at gmail.com
Tue Dec 3 16:05:53 CET 2013


Le 02/12/2013 16:27, Denis Charmet a écrit :
>> +CPL::CPL(demux_t * p_demux, string s_path, AssetList *_asset_list)
>> >+    : XmlFile(p_demux, s_path), asset_list( _asset_list)
>> >+{
>> >+    string node;
>> >+    int type;
>> >+
>> >+    if (this->OpenXml())
> There is a*LOT*  of OpenXml, why not simply give the reader of the
> parent node? it would prevent you to parse the whole file.
I did not get the point

May be because The OpenXml is called twice in CPL class
One just to verify if it is a CPL ( ie have root tag 
"CompositionPlayList") file ( to make diff from other XML files).
And one another for really parse it.




More information about the vlc-devel mailing list