[vlc-devel] [PATCH] contrib: always build fluidsynth

Rafaël Carré funman at videolan.org
Sat Dec 7 11:21:13 CET 2013


Hello,

This is a revert of b13f148fe26e9a2573438262f37860d9c2290936.

You might want to git revert this commit for the same diff but a
different log.

Also I think the log should be enhanced with something like:

"""
Don't use pkg-config to find glib, we already provide it through contrib
dependencies.
"""

Le 07/12/2013 10:47, david.fuhrmann at gmail.com a écrit :
> From: David Fuhrmann <david.fuhrmann at googlemail.com>
> 
> Glib dependency is also built in contribs now if not present.
> ---
> 
> Hi,
> I saw that fluidsynth is also missing on windows in 2.1.1 builds.
> 
> Could anyone test if this and the previous contrib patches also work for the windows build?
> 
> Best,
> David
> 
> 
>  contrib/src/fluid/rules.mak | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/contrib/src/fluid/rules.mak b/contrib/src/fluid/rules.mak
> index 8fc125a..4035979 100644
> --- a/contrib/src/fluid/rules.mak
> +++ b/contrib/src/fluid/rules.mak
> @@ -3,9 +3,7 @@
>  FLUID_VERSION := 1.1.6
>  FLUID_URL := $(SF)/fluidsynth/fluidsynth-$(FLUID_VERSION)/fluidsynth-$(FLUID_VERSION).tar.bz2
>  
> -ifeq ($(call need_pkg,"glib-2.0 gthread-2.0"),)
>  PKGS += fluid
> -endif
>  ifeq ($(call need_pkg,"fluidsynth >= 1.1.2"),)
>  PKGS_FOUND += fluid
>  endif
> 




More information about the vlc-devel mailing list